Introduce ServiceWorkerRegistrationOptions struct for service worker options

content/common/service_worker/service_worker_types.h

Index: content/common/service_worker/service_worker_types.h
diff --git a/content/common/service_worker/service_worker_types.h b/content/common/service_worker/service_worker_types.h
index a3f10c418d8177e3322f1f98eade3478c753b917..a3bf48d62b59633d2c4692bc33b659692bd03276 100644
--- a/content/common/service_worker/service_worker_types.h
+++ b/content/common/service_worker/service_worker_types.h
@@ -221,10 +221,17 @@ struct CONTENT_EXPORT ServiceWorkerObjectInfo {
   int64_t version_id;
 };
 

[nhiroki, 2017/07/07 02:02:09]

Can you add a struct-level comment like this?

// Represents options for register():
// https://w3c.github.io/ServiceWorker/v1/#dictdef-registrationoptions

[yuryu, 2017/07/10 03:38:11]

Done.

+struct CONTENT_EXPORT ServiceWorkerRegistrationOptions {
+  ServiceWorkerRegistrationOptions();

[nhiroki, 2017/07/07 02:02:09]

Is this ctor necessary?

(I guess this is required by the Chrome IPC mechanism, but want to confirm it
just in case)

[yuryu, 2017/07/10 03:38:11]

Default ctor is necessary because RegistrationOptions can be initialized without
any explicit values. I'm changing it to = default to make it clearer.

+  // Initialize |scope| with the specified value and the rest with defaults

[nhiroki, 2017/07/07 02:02:09]

s/Initialize/Initializes/

See: https://google.github.io/styleguide/cppguide.html#Function_Comments

"These comments should be descriptive ("Opens the file") rather than imperative
("Open the file");"

[falken, 2017/07/07 03:25:32]

IMO this comment is unnecessary... it's known that the constructor will
initialize with the params. Also there are no members other than |scope| now, so
it's a bit confusing.

[yuryu, 2017/07/10 03:38:10]

Removing the comment entirely.

+  explicit ServiceWorkerRegistrationOptions(const GURL& scope);
+  GURL scope;

[kinuko, 2017/07/07 02:59:31]

nit: maybe add a lightweight TODO comment to add/support other spec'ed options
(to clarify why we need this struct)

[yuryu, 2017/07/10 03:38:10]

Done.

+};
+
 struct CONTENT_EXPORT ServiceWorkerRegistrationObjectInfo {
   ServiceWorkerRegistrationObjectInfo();
   int handle_id;
-  GURL scope;
+  ServiceWorkerRegistrationOptions options;
   int64_t registration_id;
 };