content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc - Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_core.h ('K') | « content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.h » ('j') | content/browser/service_worker/service_worker_job_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc

diff --git a/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc b/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc

index f916b5b0138777070dac115b7128af99914873da..35a64d5f6f78fdc144ec4e5383864d147dbff0ae 100644

--- a/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc

+++ b/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc

@@ -78,8 +78,9 @@ class ServiceWorkerDataPipeReaderTest

helper_ = base::MakeUnique<EmbeddedWorkerTestHelper>(base::FilePath());

mock_url_request_job_ =

base::MakeUnique<MockServiceWorkerURLRequestJob>(this);

+ ServiceWorkerRegistrationOptions options(GURL("https://example.com/"));

registration_ = new ServiceWorkerRegistration(

- GURL("https://example.com/"), 1L, helper_->context()->AsWeakPtr());

+ options, 1L, helper_->context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(

registration_.get(), GURL("https://example.com/service_worker.js"), 1L,

helper_->context()->AsWeakPtr());