Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2968023002: Duplicate change from NodeLocator to NodeLocator2 (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
NodeLocator was changed to support fasta, but NodeLocator2 was missed. I think the same change ...
3 years, 5 months ago (2017-07-05 17:32:22 UTC) #2
danrubel
Good catch. Thanks! LGTM
3 years, 5 months ago (2017-07-05 18:10:15 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-07-05 18:24:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9bb89bc02692aba4f8cf3436200931a228380812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698