Chromium Code Reviews| Index: ipc/ipc_fuzzing_tests.cc |
| diff --git a/ipc/ipc_fuzzing_tests.cc b/ipc/ipc_fuzzing_tests.cc |
| index 8e385bc34fe828bca88d781a26628dab6e7da953..91637dcae0afd4cb0f10f41fd206a63713a0aa5f 100644 |
| --- a/ipc/ipc_fuzzing_tests.cc |
| +++ b/ipc/ipc_fuzzing_tests.cc |
| @@ -94,12 +94,7 @@ TEST(IPCMessageIntegrity, ReadVectorNegativeSize) { |
| EXPECT_FALSE(ReadParam(&m, &iter, &vec)); |
| } |
| -#if defined(OS_ANDROID) |
| -#define MAYBE_ReadVectorTooLarge1 DISABLED_ReadVectorTooLarge1 |
| -#else |
| -#define MAYBE_ReadVectorTooLarge1 ReadVectorTooLarge1 |
| -#endif |
|
dcheng
2017/07/13 22:25:07
Is it confirmed that this isn't a problem for the
Hzj_jie
2017/07/14 00:25:09
Looks like I should not try to include this change
|
| -TEST(IPCMessageIntegrity, MAYBE_ReadVectorTooLarge1) { |
| +TEST(IPCMessageIntegrity, ReadVectorTooLarge1) { |
| // This was BUG 1006367. This is the large but positive length case. Again |
| // we try to hit the non-specialized case vector<P>. |
| IPC::Message m(0, 1, IPC::Message::PRIORITY_NORMAL); |
| @@ -126,6 +121,20 @@ TEST(IPCMessageIntegrity, ReadVectorTooLarge2) { |
| EXPECT_FALSE(ReadParam(&m, &iter, &vec)); |
| } |
| +// This test needs ~20 seconds in Debug mode, or ~4 seconds in Release mode. |
| +// See http://crbug.com/741866 for details. |
| +TEST(IPCMessageIntegrity, DISABLE_ReadVectorTooLarge3) { |
|
dcheng
2017/07/13 22:25:07
Nit: DISABLED
Hzj_jie
2017/07/14 00:25:09
Done.
|
| + base::Pickle pickle; |
| + IPC::WriteParam(&pickle, 256 * 1024 * 1024); |
| + IPC::WriteParam(&pickle, 0); |
| + IPC::WriteParam(&pickle, 1); |
| + IPC::WriteParam(&pickle, 2); |
| + |
| + base::PickleIterator iter(pickle); |
| + std::vector<int> vec; |
| + EXPECT_FALSE(IPC::ReadParam(&pickle, &iter, &vec)); |
| +} |
| + |
| class SimpleListener : public IPC::Listener { |
| public: |
| SimpleListener() : other_(NULL) { |