Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2967933002: Bring js_model/model_test on par with compile_from_dill tests. (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bring js_model/model_test on par with compile_from_dill tests. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/69421f0f62adfcc76b9077bcda11ea7b60f58f8d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -83 lines) Patch
M pkg/compiler/lib/src/js_model/elements.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 2 chunks +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 6 chunks +8 lines, -11 lines 1 comment Download
M tests/compiler/dart2js/js_model/model_test.dart View 2 chunks +27 lines, -57 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-04 13:11:31 UTC) #2
Siggi Cherem (dart-lang)
sweet! lgtm https://codereview.chromium.org/2967933002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (left): https://codereview.chromium.org/2967933002/diff/1/pkg/compiler/lib/src/world.dart#oldcode448 pkg/compiler/lib/src/world.dart:448: final ResolutionWorldBuilder _resolverWorld; \o/ |
3 years, 5 months ago (2017-07-05 21:00:09 UTC) #3
Johnni Winther
3 years, 5 months ago (2017-07-06 14:38:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69421f0f62adfcc76b9077bcda11ea7b60f58f8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698