gyp/common_conditions.gypi - Issue 296793003: Remove -mfpmath=sse for clang, which does it automatically and sometimes is annoyed by it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/common_conditions.gypi

Issue 296793003: Remove -mfpmath=sse for clang, which does it automatically and sometimes is annoyed by it. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gyp/common_conditions.gypi

diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi

index a745c706dad2c8876f027f58dcfb61f8baca3fbd..20911cb42ffe0d8fe94b1e5344641c9d38c09750 100644

--- a/gyp/common_conditions.gypi

+++ b/gyp/common_conditions.gypi

@@ -435,6 +435,9 @@

# Extra warnings we like but that only Clang knows about.

'-Wstring-conversion',

+ 'cflags!': [

+ '-mfpmath=sse', # Clang doesn't need to be told this, and sometimes gets confused.

+ ],

}],

[ 'skia_keep_frame_pointer', {

'cflags': [ '-fno-omit-frame-pointer' ],

« no previous file with comments | « no previous file | no next file » | no next file with comments »