Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart

Issue 2967923002: Use type variables on Typedef correctly. (Closed)
Patch Set: Fix NPE and change compile-time error to warning. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart b/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
index 5c424d8fb93d14ed9725723beca95910b30cf0e3..2d7b21bd7b95936a2596729c3ef6f4c00dc5ed80 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
@@ -4,40 +4,36 @@
library fasta.dill_typedef_builder;
-import 'package:front_end/src/fasta/builder/library_builder.dart';
-import 'package:front_end/src/fasta/errors.dart';
import 'package:kernel/ast.dart' show DartType, Typedef;
+import 'package:front_end/src/fasta/errors.dart' show internalError;
+
import '../kernel/kernel_builder.dart'
show
- FormalParameterBuilder,
KernelFunctionTypeAliasBuilder,
- KernelTypeBuilder,
+ KernelFunctionTypeBuilder,
+ LibraryBuilder,
MetadataBuilder,
TypeVariableBuilder;
+
import 'dill_library_builder.dart' show DillLibraryBuilder;
class DillFunctionTypeAliasBuilder extends KernelFunctionTypeAliasBuilder {
DillFunctionTypeAliasBuilder(Typedef typedef, DillLibraryBuilder parent)
- : super(null, null, typedef.name, null, null, parent, typedef.fileOffset,
+ : super(null, typedef.name, null, null, parent, typedef.fileOffset,
typedef);
- @override
- List<FormalParameterBuilder> get formals {
- return internalError('Not implemented.');
- }
-
List<MetadataBuilder> get metadata {
return internalError('Not implemented.');
}
@override
- KernelTypeBuilder get returnType {
+ List<TypeVariableBuilder> get typeVariables {
return internalError('Not implemented.');
}
@override
- List<TypeVariableBuilder> get typeVariables {
+ KernelFunctionTypeBuilder get type {
return internalError('Not implemented.');
}

Powered by Google App Engine
This is Rietveld 408576698