Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: pkg/front_end/lib/src/fasta/source/source_library_builder.dart

Issue 2967923002: Use type variables on Typedef correctly. (Closed)
Patch Set: Fix NPE and change compile-time error to warning. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.source_library_builder; 5 library fasta.source_library_builder;
6 6
7 import 'package:front_end/src/scanner/token.dart' show Token; 7 import 'package:front_end/src/scanner/token.dart' show Token;
8 8
9 import 'package:kernel/ast.dart' show ProcedureKind; 9 import 'package:kernel/ast.dart' show ProcedureKind;
10 10
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 int charOpenParenOffset, 236 int charOpenParenOffset,
237 int charEndOffset, 237 int charEndOffset,
238 String nativeMethodName, 238 String nativeMethodName,
239 {bool isTopLevel}); 239 {bool isTopLevel});
240 240
241 void addEnum(List<MetadataBuilder> metadata, String name, 241 void addEnum(List<MetadataBuilder> metadata, String name,
242 List<Object> constantNamesAndOffsets, int charOffset, int charEndOffset); 242 List<Object> constantNamesAndOffsets, int charOffset, int charEndOffset);
243 243
244 void addFunctionTypeAlias( 244 void addFunctionTypeAlias(
245 List<MetadataBuilder> metadata, 245 List<MetadataBuilder> metadata,
246 T returnType,
247 String name, 246 String name,
248 List<TypeVariableBuilder> typeVariables, 247 List<TypeVariableBuilder> typeVariables,
249 List<FormalParameterBuilder> formals, 248 FunctionTypeBuilder type,
250 int charOffset); 249 int charOffset);
251 250
252 FunctionTypeBuilder addFunctionType( 251 FunctionTypeBuilder addFunctionType(
253 T returnType, 252 T returnType,
254 List<TypeVariableBuilder> typeVariables, 253 List<TypeVariableBuilder> typeVariables,
255 List<FormalParameterBuilder> formals, 254 List<FormalParameterBuilder> formals,
256 int charOffset); 255 int charOffset);
257 256
258 void addFactoryMethod( 257 void addFactoryMethod(
259 List<MetadataBuilder> metadata, 258 List<MetadataBuilder> metadata,
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 /// synthesize type variables on the factory matching the class'. 608 /// synthesize type variables on the factory matching the class'.
610 void addFactoryDeclaration( 609 void addFactoryDeclaration(
611 ProcedureBuilder procedure, DeclarationBuilder<T> factoryDeclaration) { 610 ProcedureBuilder procedure, DeclarationBuilder<T> factoryDeclaration) {
612 factoryDeclarations[procedure] = factoryDeclaration; 611 factoryDeclarations[procedure] = factoryDeclaration;
613 } 612 }
614 613
615 Scope toScope(Scope parent) { 614 Scope toScope(Scope parent) {
616 return new Scope(members, setters, parent, isModifiable: false); 615 return new Scope(members, setters, parent, isModifiable: false);
617 } 616 }
618 } 617 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698