third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 2967893002: Display arrow cursor instead of i-beam when selection is not present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2967893002: Display arrow cursor instead of i-beam when selection is not present (Closed)

Patch Set: layout test case updated Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index 89cbf41dababfdd287484efbe736920b2dd0150f..11f4883ba3f12857ae3b80fbf3596a6cdfdc6498 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -552,9 +552,9 @@ OptionalCursor EventHandler::SelectAutoCursor(const HitTestResult& result,

if (mouse_event_manager_->MousePressed() &&

GetSelectionController().MouseDownMayStartSelect() &&

!mouse_event_manager_->MouseDownMayStartDrag() &&

- !frame_->Selection()

- .ComputeVisibleSelectionInDOMTreeDeprecated()

- .IsNone() &&

+ frame_->Selection()

+ .ComputeVisibleSelectionInDOMTreeDeprecated()

+ .IsRange() &&

!capturing_mouse_events_node_) {

return i_beam;

}