Display arrow cursor instead of i-beam when selection is not present

third_party/WebKit/Source/core/input/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 527 matching lines @@
   if (result.GetScrollbar()) {
     return PointerCursor();
   }
 
   const bool is_over_link =
       !GetSelectionController().MouseDownMayStartSelect() &&
       result.IsOverLink();
   if (UseHandCursor(node, is_over_link))
     return HandCursor();
 
   // During selection, use an I-beam no matter what we're over.

[hugoh_UTC2, 2017/07/11 09:36:39]

http://crbug.com/735852 shows that this comment is wrong. We do not want to "use
an I-beam no matter what we're over".

Is this block only needed when selecting links ?

I did an experiment here: https://chromium-review.googlesource.com/c/566798/ 

   // If a drag may be starting or we're capturing mouse events for a particular
   // node, don't treat this as a selection. Note calling
   // ComputeVisibleSelectionInDOMTreeDeprecated may update layout.
   if (mouse_event_manager_->MousePressed() &&
       GetSelectionController().MouseDownMayStartSelect() &&
       !mouse_event_manager_->MouseDownMayStartDrag() &&
-      !frame_->Selection()

[yosin_UTC9, 2017/07/05 01:27:45]

The issue is caused by hidden selection regarding to bisect[1].
Thus, suggested change is checking |!frame->Selection().IsHidden()|.
We should use i-beam for both caret/range selection.


[1] https://bugs.chromium.org/p/chromium/issues/detail?id=735852#c1 

-           .ComputeVisibleSelectionInDOMTreeDeprecated()
-           .IsNone() &&
+      frame_->Selection()
+          .ComputeVisibleSelectionInDOMTreeDeprecated()
+          .IsRange() &&
       !capturing_mouse_events_node_) {
     return i_beam;
   }
 
   if (ShouldShowIBeamForNode(node, result))
     return i_beam;
   return PointerCursor();
 }
 
 WebInputEventResult EventHandler::HandleMousePressEvent(
@@ skipping 1528 matching lines @@
     MouseEventWithHitTestResults& mev,
     LocalFrame* subframe) {
   WebInputEventResult result =
       subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event());
   if (result != WebInputEventResult::kNotHandled)
     return result;
   return WebInputEventResult::kHandledSystem;
 }
 
 }  // namespace blink