third_party/WebKit/LayoutTests/fast/events/mouse-cursor-change.html - Issue 2967893002: Display arrow cursor instead of i-beam when selection is not present

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/mouse-cursor-change.html

Issue 2967893002: Display arrow cursor instead of i-beam when selection is not present (Closed)

Patch Set: updated patch with expected file Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/mouse-cursor-change-expected.txt » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 <style type="text/css">	5 <style type="text/css">

6 </style>	6 </style>

7 </head>	7 </head>

8 <body>	8 <body>

9 <p id="description"></p>	9 <p id="description"></p>

10 <p><a href="https://bugs.webkit.org/show_bug.cgi?id=53341">Bug 53341</a></p>	10 <p><a href="https://bugs.webkit.org/show_bug.cgi?id=53341">Bug 53341</a></p>

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 eventSender.mouseMoveTo(target.offsetLeft + 3, target.offsetTop + 3) ;	55 eventSender.mouseMoveTo(target.offsetLeft + 3, target.offsetTop + 3) ;

56 }, function() {	56 }, function() {

57 debug('Mouse down');	57 debug('Mouse down');

58 eventSender.mouseDown();	58 eventSender.mouseDown();

59 }, function() {	59 }, function() {

60 debug('Mouse hold down, move');	60 debug('Mouse hold down, move');

61 eventSender.mouseMoveTo(target.offsetLeft + 13, target.offsetTop + 3 );	61 eventSender.mouseMoveTo(target.offsetLeft + 13, target.offsetTop + 3 );

62 }, function() {	62 }, function() {

63 debug('Mouse up');	63 debug('Mouse up');

64 eventSender.mouseUp();	64 eventSender.mouseUp();

	65 }, function() {

	66 // If selection is not happening and mouse is pressed, then pointer cursor should be shown.
	hugoh_UTC2 2017/07/06 11:59:33 "When a drag neither modifies nor creates a select "When a drag neither modifies nor creates a selection, pointer cursor should be shown."
	67 debug('Mouse move');

	68 eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth + 50, target.offsetTop + target.offsetHeight + 100);

	69 }, function() {
	hugoh_UTC2 2017/07/06 11:59:33 I think this test should go into a new file (becau I think this test should go into a new file (because this is a new bug) that only tests BUG=735852. Testing 735852 does not need CURSOR_UPDATE_DELAY. No CSS needs to be involved to test this, so no need to wait for style update. "cursor is updated immediately on mouse events"
	70 debug('Mouse down');

	71 eventSender.mouseDown();

	72 }, function() {

	73 eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth + 90, target.offsetTop + target.offsetHeight + 100);

	74 debug('Mouse hold down, move');

	75 eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth + 160 , target.offsetTop + target.offsetHeight + 100);

	76 }, function() {

	77 debug('Mouse up');

	78 eventSender.mouseUp();

65 }	79 }

66 ];	80 ];

67	81

68 var i = 0;	82 var i = 0;

69 function nextTest() {	83 function nextTest() {

70 if (i < tests.length) {	84 if (i < tests.length) {

71 runTest(tests[i++], nextTest);	85 runTest(tests[i++], nextTest);

72 } else {	86 } else {

73 testsDone();	87 testsDone();

74 }	88 }

75 }	89 }

76 nextTest();	90 nextTest();

77 }	91 }

78	92

79 </script>	93 </script>

80 </body>	94 </body>

81 </html>	95 </html>

OLD	NEW