Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2967883002: Make analyzer respect exclusions from the analysis options file (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
devoncarew, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make analyzer respect exclusions from the analysis options file R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/895f898b9b943729412ba210752bfcabf451be04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 3 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-07-04 00:32:13 UTC) #2
devoncarew
Awesome! And it's a small patch :) Perhaps add a test that we do exclude ...
3 years, 5 months ago (2017-07-04 02:54:19 UTC) #3
Brian Wilkerson
Yes, we should definitely add a test. I'm going to commit this without, though, in ...
3 years, 5 months ago (2017-07-05 13:11:25 UTC) #4
devoncarew
lgtm
3 years, 5 months ago (2017-07-05 14:02:26 UTC) #5
Brian Wilkerson
Committed patchset #1 (id:1) manually as 895f898b9b943729412ba210752bfcabf451be04 (presubmit successful).
3 years, 5 months ago (2017-07-05 14:52:53 UTC) #7
scheglov
3 years, 5 months ago (2017-07-05 15:16:34 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698