Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2967843002: Add EquivalenceVisitor to tools in js_ast (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -501 lines) Patch
M pkg/js_ast/lib/js_ast.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A pkg/js_ast/lib/src/equivalence_visitor.dart View 1 1 chunk +503 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/equivalence/check_functions.dart View 2 chunks +19 lines, -501 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-03 12:16:21 UTC) #2
sra1
lgtm https://codereview.chromium.org/2967843002/diff/1/pkg/js_ast/lib/js_ast.dart File pkg/js_ast/lib/js_ast.dart (right): https://codereview.chromium.org/2967843002/diff/1/pkg/js_ast/lib/js_ast.dart#newcode15 pkg/js_ast/lib/js_ast.dart:15: part 'src/tools.dart'; perhaps call this something like equivalence_visitor.dart ...
3 years, 5 months ago (2017-07-05 21:18:33 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 09c58282049acca9a411b068360ca733ada7300f (presubmit successful).
3 years, 5 months ago (2017-07-06 08:39:35 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-06 08:39:39 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2967843002/diff/1/pkg/js_ast/lib/js_ast.dart
File pkg/js_ast/lib/js_ast.dart (right):

https://codereview.chromium.org/2967843002/diff/1/pkg/js_ast/lib/js_ast.dart#...
pkg/js_ast/lib/js_ast.dart:15: part 'src/tools.dart';
On 2017/07/05 21:18:33, sra1 wrote:
> perhaps call this something like equivalence_visitor.dart
> 
> If we add more 'tools', they would be better off in a separate file rather
than
> mixed in with a 500 line class.

Done.

Powered by Google App Engine
This is Rietveld 408576698