Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2967833002: Don't use file-based part-of when part files are shared. (Closed)

Created:
3 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use file-based part-of when part files are shared. Committed: https://github.com/dart-lang/sdk/commit/03491d6ed73d8774c14f839e29f21dc5980c634d

Patch Set 1 #

Patch Set 2 : Don't overdo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sdk/lib/html/html_common/conversions.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/conversions_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/css_class_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/device.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/lists.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
TBR
3 years, 5 months ago (2017-07-03 11:46:07 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 03491d6ed73d8774c14f839e29f21dc5980c634d (presubmit successful).
3 years, 5 months ago (2017-07-03 11:48:29 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-03 11:49:26 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698