remoting/protocol/data_channel_manager.cc - Issue 2967793002: [Chromoting] Remove DataChannelManagerCallbacks constructor parameter of ClientSession

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/data_channel_manager.cc

Issue 2967793002: [Chromoting] Remove DataChannelManagerCallbacks constructor parameter of ClientSession (Closed)

Patch Set: Resolve review comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/data_channel_manager.cc

diff --git a/remoting/protocol/data_channel_manager.cc b/remoting/protocol/data_channel_manager.cc

index c8f0782f38dafcef4d286a3b5bc5ed3d331bf49c..aa2914ed5ce4849f479a49ca0dfcbeccf00e74ab 100644

--- a/remoting/protocol/data_channel_manager.cc

+++ b/remoting/protocol/data_channel_manager.cc

@@ -20,7 +20,7 @@ void DataChannelManager::RegisterCreateHandlerCallback(

CreateHandlerCallback constructor) {

DCHECK(!prefix.empty());

DCHECK(constructor);

- constructors_.push_back(std::make_pair(prefix, constructor));

+ constructors_.push_back(std::make_pair(prefix, std::move(constructor)));

}

bool DataChannelManager::OnIncomingDataChannel(

« no previous file with comments | « remoting/protocol/data_channel_manager.h ('k') | remoting/test/it2me_standalone_host.cc » ('j') | no next file with comments »