Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2967733002: Fix PaintTiming Web Perf APIs for FP & FCP not reporting swap time (Closed)

Created:
3 years, 5 months ago by shaseley
Modified:
3 years, 4 months ago
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PaintTiming Web Perf APIs for FP & FCP not reporting swap time The PaintTimings were being added in ReportSwapTime(), but not using the swap timestamps set there. BUG=738575 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Add TODO for layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/basetest.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
shaseley
Hi folks, this is a fix to a previous change you reviewed for updating the ...
3 years, 5 months ago (2017-06-30 22:56:26 UTC) #3
panicker
LGTM. Thanks for catching this and the fix!
3 years, 5 months ago (2017-07-01 01:22:35 UTC) #8
tdresser
It would be really nice to have some test coverage here. Shubhie, any thoughts on ...
3 years, 5 months ago (2017-07-04 14:51:17 UTC) #9
panicker
On 2017/07/04 14:51:17, tdresser (OOO until July 17) wrote: > It would be really nice ...
3 years, 5 months ago (2017-07-11 22:06:46 UTC) #10
panicker
On 2017/07/11 22:06:46, panicker wrote: > On 2017/07/04 14:51:17, tdresser (OOO until July 17) wrote: ...
3 years, 5 months ago (2017-07-11 22:09:03 UTC) #11
shaseley
On 2017/07/11 22:09:03, panicker wrote: > On 2017/07/11 22:06:46, panicker wrote: > > On 2017/07/04 ...
3 years, 5 months ago (2017-07-17 14:57:42 UTC) #12
panicker
Steve, can you review for OWNERS?
3 years, 5 months ago (2017-07-17 18:15:03 UTC) #14
skobes
rs lgtm
3 years, 5 months ago (2017-07-17 18:53:27 UTC) #15
shaseley
3 years, 4 months ago (2017-07-26 22:46:21 UTC) #16
I'm closing this issue without committing. We now want to make sure we report
the metrics consistently between UMAs, TBMs, UKMs, and web perf API, and this is
CL is subsumed by  https://chromium-review.googlesource.com/c/576371/.

Powered by Google App Engine
This is Rietveld 408576698