Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 296773003: Add ChromeOS expectations to gpu webgl conformance. (Closed)

Created:
6 years, 7 months ago by ilja
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, Zhenyao Mo
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Add ChromeOS expectation to gpu webgl conformance. The lab logs show us that conformance/ogles/GL/build/build_009_to_016.html is intermittent on all Atom Chromebooks. BUG=chromium:378938 TEST=None

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
ilja
Please take a look!
6 years, 7 months ago (2014-05-21 05:00:25 UTC) #1
marcheu
lgtm
6 years, 7 months ago (2014-05-21 15:01:29 UTC) #2
tbarzic
lgtm
6 years, 7 months ago (2014-05-21 16:36:42 UTC) #3
Ken Russell (switch to Gerrit)
LGTM +bajones,zmo as FYI
6 years, 7 months ago (2014-05-21 20:54:38 UTC) #4
ilja
The CQ bit was checked by ihf@chromium.org
6 years, 7 months ago (2014-05-21 20:59:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/296773003/20001
6 years, 7 months ago (2014-05-21 21:04:16 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 04:15:19 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 04:21:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69103)
6 years, 7 months ago (2014-05-22 04:21:30 UTC) #9
ilja
The CQ bit was checked by ihf@chromium.org
6 years, 7 months ago (2014-05-22 05:36:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/296773003/20001
6 years, 7 months ago (2014-05-22 05:42:02 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 05:51:02 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 05:55:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69115)
6 years, 7 months ago (2014-05-22 05:55:33 UTC) #14
ilja
The CQ bit was checked by ihf@chromium.org
6 years, 7 months ago (2014-05-22 08:36:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/296773003/20001
6 years, 7 months ago (2014-05-22 08:37:18 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 08:44:41 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 08:52:11 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69147)
6 years, 7 months ago (2014-05-22 08:52:13 UTC) #19
ilja
It has warnings that some of the lines are > 80 characters but I don't ...
6 years, 7 months ago (2014-05-22 17:20:47 UTC) #20
tbarzic
On 2014/05/22 17:20:47, ilja wrote: > It has warnings that some of the lines are ...
6 years, 7 months ago (2014-05-22 17:26:38 UTC) #21
bajones
On 2014/05/22 17:20:47, ilja wrote: > It has warnings that some of the lines are ...
6 years, 7 months ago (2014-05-22 17:28:08 UTC) #22
ilja
The CQ bit was checked by ihf@chromium.org
6 years, 7 months ago (2014-05-23 00:42:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/296773003/40001
6 years, 7 months ago (2014-05-23 00:44:55 UTC) #24
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 00:47:10 UTC) #25
Message was sent while issue was closed.
Change committed as 272384

Powered by Google App Engine
This is Rietveld 408576698