Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 296773002: Add a Key class (Closed)

Created:
6 years, 7 months ago by bartfab (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add a Key class This CL generalizes the UserContext::password_ field into a Key class which can hold a plain text password, a key derived from a password by hashing or, in the future, other key types. BUG=367847 TEST=Updated tests; added new unit test R=antrim@chromium.org TBR=pamg (c/b/managed_mode/chromeos/manager_password_service.[h|cc]) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272963

Patch Set 1 #

Patch Set 2 : Updated tests. #

Patch Set 3 : Fix interactive_ui_tests compilation. #

Patch Set 4 : Fix typos. #

Patch Set 5 : Fix Key copy constructor. #

Patch Set 6 : Ready for review. #

Patch Set 7 : Rebased. #

Patch Set 8 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -613 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/extended_authenticator.h View 5 chunks +42 lines, -66 lines 0 comments Download
M chrome/browser/chromeos/login/auth/extended_authenticator.cc View 12 chunks +82 lines, -105 lines 0 comments Download
A chrome/browser/chromeos/login/auth/key.h View 1 2 3 4 5 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/key.cc View 1 2 3 4 5 1 chunk +117 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/key_unittest.cc View 1 2 3 4 5 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/login_performer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/auth/mock_authenticator.h View 1 2 chunks +9 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/login/auth/mock_authenticator.cc View 1 4 chunks +39 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.h View 1 2 3 4 5 6 7 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.cc View 1 2 3 4 5 6 7 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.cc View 1 7 chunks +39 lines, -48 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc View 1 16 chunks +61 lines, -62 lines 0 comments Download
M chrome/browser/chromeos/login/auth/user_context.h View 1 2 3 4 5 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/auth/user_context.cc View 1 2 3 5 chunks +16 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 4 5 6 7 13 chunks +34 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 1 2 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_tester.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_tester.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.h View 1 2 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 1 3 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_authenticator.cc View 1 3 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc View 1 2 3 4 5 3 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_creation_controller_old.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_test_base.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_authentication.h View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_authentication.cc View 1 2 3 4 5 6 chunks +10 lines, -48 lines 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_authentication_unittest.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_login_flow.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.h View 1 2 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 4 5 6 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/managed_mode/chromeos/manager_password_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/chromeos/manager_password_service.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 6 7 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 34 (0 generated)
bartfab (slow)
Hi Denis, Can you please review?
6 years, 7 months ago (2014-05-22 14:54:20 UTC) #1
bartfab (slow)
Hi Nikita, would you mind taking a look at this CL while Denis is out ...
6 years, 7 months ago (2014-05-23 16:17:13 UTC) #2
Denis Kuznetsov (DE-MUC)
lgtm
6 years, 7 months ago (2014-05-26 12:07:42 UTC) #3
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-26 12:16:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/296773002/100001
6 years, 7 months ago (2014-05-26 12:17:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 12:46:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 12:50:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/28435)
6 years, 7 months ago (2014-05-26 12:50:26 UTC) #8
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-26 14:27:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/296773002/120001
6 years, 7 months ago (2014-05-26 14:28:40 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 18:19:46 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 18:25:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/31015)
6 years, 7 months ago (2014-05-26 18:25:18 UTC) #13
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-26 18:32:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/296773002/120001
6 years, 7 months ago (2014-05-26 18:33:07 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 18:42:57 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 18:47:06 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/31020)
6 years, 7 months ago (2014-05-26 18:47:07 UTC) #18
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-27 09:20:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/296773002/120001
6 years, 7 months ago (2014-05-27 09:21:10 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 09:30:52 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 09:35:48 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/31150)
6 years, 7 months ago (2014-05-27 09:35:48 UTC) #23
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-27 09:49:00 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/296773002/140001
6 years, 7 months ago (2014-05-27 09:49:13 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 13:13:43 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 13:22:25 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77889)
6 years, 7 months ago (2014-05-27 13:22:26 UTC) #28
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-27 13:23:18 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/296773002/140001
6 years, 7 months ago (2014-05-27 13:23:28 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 13:29:42 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 13:35:19 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77892)
6 years, 7 months ago (2014-05-27 13:35:20 UTC) #33
bartfab (slow)
6 years, 7 months ago (2014-05-27 13:46:44 UTC) #34
Message was sent while issue was closed.
Committed patchset #8 manually as r272963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698