Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2967703003: Change Timeline Page presets UI from Select to Buttons (Closed)

Created:
3 years, 5 months ago by cbernaschina
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Timeline Page presets UI from Select to Buttons Related=https://github.com/dart-lang/sdk/issues/29275 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3ad05774426e9d475d632dc0f3b99f8fc49295b7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M runtime/observatory/lib/src/elements/timeline_page.dart View 6 chunks +15 lines, -23 lines 2 comments Download

Messages

Total messages: 6 (3 generated)
cbernaschina
3 years, 5 months ago (2017-06-30 18:55:07 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2967703003/diff/1/runtime/observatory/lib/src/elements/timeline_page.dart File runtime/observatory/lib/src/elements/timeline_page.dart (right): https://codereview.chromium.org/2967703003/diff/1/runtime/observatory/lib/src/elements/timeline_page.dart#newcode23 runtime/observatory/lib/src/elements/timeline_page.dart:23: enum _Profile { none, all, dart, vm } ...
3 years, 5 months ago (2017-06-30 22:01:11 UTC) #4
cbernaschina
3 years, 5 months ago (2017-06-30 23:20:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3ad05774426e9d475d632dc0f3b99f8fc49295b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698