Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2967593002: [kernel] Cache patch-classes. (Closed)

Created:
3 years, 5 months ago by jensj
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Cache patch-classes. Via kernel we create PatchClasses to make sure the correct script is set for functions and fields. Currently we create a new PatchClass each time we need one, but often an old one could easily be reused. This CL implements a simple caching-scheme and often uses a cached version. Because some are requested out-of-order "duplicate" PatchClasses can still be created though. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/7952514f083880402afcf84be9c240e5407b9bf5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M runtime/vm/kernel_reader.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 5 months ago (2017-06-30 07:59:24 UTC) #2
Kevin Millikin (Google)
lgtm
3 years, 4 months ago (2017-08-08 09:38:48 UTC) #3
jensj
3 years, 4 months ago (2017-08-09 09:01:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7952514f083880402afcf84be9c240e5407b9bf5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698