Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3206)

Unified Diff: ash/shelf/shelf_layout_manager_unittest.cc

Issue 2967543003: collect windows from mru_list in workspace_controller. (Closed)
Patch Set: add unittest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/workspace_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_layout_manager_unittest.cc
diff --git a/ash/shelf/shelf_layout_manager_unittest.cc b/ash/shelf/shelf_layout_manager_unittest.cc
index a6e92da075ea3c69f89dbf4acc3f81289b754832..0adc1ebbfaca8ef442ddb04d97739d48927ad013 100644
--- a/ash/shelf/shelf_layout_manager_unittest.cc
+++ b/ash/shelf/shelf_layout_manager_unittest.cc
@@ -1559,6 +1559,12 @@ TEST_F(ShelfLayoutManagerTest, AutohideShelfForAutohideWhenActiveWindow) {
->set_autohide_shelf_when_maximized_or_fullscreen(false);
widget_two->Activate();
EXPECT_EQ(SHELF_VISIBLE, shelf->GetVisibilityState());
+
+ wm::GetWindowState(window_two)
+ ->set_autohide_shelf_when_maximized_or_fullscreen(true);
+ window_two->SetProperty(aura::client::kAlwaysOnTopKey, true);
oshima 2017/06/30 00:04:08 please test if the window is in the always on cont
Muyuan 2017/06/30 00:28:23 Done.
+ widget_two->Maximize();
+ EXPECT_EQ(SHELF_AUTO_HIDE, shelf->GetVisibilityState());
oshima 2017/06/30 00:04:08 Can you also check if the workspace state is in ma
Muyuan 2017/06/30 00:28:23 Done.
}
TEST_F(ShelfLayoutManagerTest, ShelfFlickerOnTrayActivation) {
« no previous file with comments | « no previous file | ash/wm/workspace_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698