Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: ash/app_list/app_list_presenter_delegate_unittest.cc

Issue 2967543003: collect windows from mru_list in workspace_controller. (Closed)
Patch Set: address review comment Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/app_list/app_list_presenter_delegate.cc ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/app_list/app_list_presenter_delegate_unittest.cc
diff --git a/ash/app_list/app_list_presenter_delegate_unittest.cc b/ash/app_list/app_list_presenter_delegate_unittest.cc
index 10c6b451e352758ea1c30255dc1b89bbd859bd0c..499c8d419b0d440f83f70b7e4efef00a1dc2b89f 100644
--- a/ash/app_list/app_list_presenter_delegate_unittest.cc
+++ b/ash/app_list/app_list_presenter_delegate_unittest.cc
@@ -700,7 +700,7 @@ TEST_F(AppListPresenterDelegateTest,
EXPECT_TRUE(app_list::features::IsFullscreenAppListEnabled());
EXPECT_FALSE(GetPrimaryShelf()->IsHorizontalAlignment());
EXPECT_EQ(GetPrimaryShelf()->shelf_layout_manager()->GetShelfBackgroundType(),
- SHELF_BACKGROUND_DEFAULT);
oshima 2017/07/13 04:41:32 This should stay right?
Muyuan 2017/07/13 18:46:01 It should be OVERLAP per UX requirement. The test
+ SHELF_BACKGROUND_OVERLAP);
}
// Tests that the half app list closes if the user taps outside its bounds.
« no previous file with comments | « ash/app_list/app_list_presenter_delegate.cc ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698