Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: components/password_manager/core/browser/site_affiliation/asset_link_retriever.h

Issue 2967503003: Introduce a parse for digital asset links. (Closed)
Patch Set: Fix compilation Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/site_affiliation/asset_link_retriever.h
diff --git a/components/password_manager/core/browser/site_affiliation/asset_link_retriever.h b/components/password_manager/core/browser/site_affiliation/asset_link_retriever.h
index 42ae1a121ce0f1cdbdbd6480cc298e5a7fb6989f..2beecdf7377af89f7b88f662227c6552f93b66f0 100644
--- a/components/password_manager/core/browser/site_affiliation/asset_link_retriever.h
+++ b/components/password_manager/core/browser/site_affiliation/asset_link_retriever.h
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "components/password_manager/core/browser/site_affiliation/asset_link_data.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "url/gurl.h"
@@ -29,6 +30,7 @@ class AssetLinkRetriever : public base::RefCounted<AssetLinkRetriever>,
enum class State {
INACTIVE,
NETWORK_REQUEST,
+ PARSING,
FINISHED,
};
@@ -42,6 +44,9 @@ class AssetLinkRetriever : public base::RefCounted<AssetLinkRetriever>,
bool error() const { return error_; }
+ const std::vector<GURL>& includes() const { return data_.includes(); }
+ const std::vector<GURL>& targets() const { return data_.targets(); }
+
private:
friend class base::RefCounted<AssetLinkRetriever>;
~AssetLinkRetriever() override;
@@ -49,6 +54,8 @@ class AssetLinkRetriever : public base::RefCounted<AssetLinkRetriever>,
// net::URLFetcherDelegate:
void OnURLFetchComplete(const net::URLFetcher* source) override;
+ void OnResponseParsed(std::unique_ptr<AssetLinkData> data, bool result);
+
// URL of the file retrieved.
const GURL url_;
@@ -58,6 +65,9 @@ class AssetLinkRetriever : public base::RefCounted<AssetLinkRetriever>,
// Whether the reading finished with error.
bool error_;
+ // Actual data from the asset link.
+ AssetLinkData data_;
+
std::unique_ptr<net::URLFetcher> fetcher_;
DISALLOW_COPY_AND_ASSIGN(AssetLinkRetriever);

Powered by Google App Engine
This is Rietveld 408576698