pkg/analyzer/lib/src/summary/summarize_ast.dart - Issue 2967503002: Fix the resolution of uri-based part-of directives in the SDK (issue 29598)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 2967503002: Fix the resolution of uri-based part-of directives in the SDK (issue 29598) (Closed)

Patch Set: moved test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/summary/summarize_ast.dart

diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart

index 2ca188cf564af7ee1a547cf7de40862e2bbb3e31..e1d45ce408f4c4edcaa49a4adf1d732065772ad1 100644

--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart

+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart

@@ -1437,7 +1437,8 @@ class _SummarizeAstVisitor extends RecursiveAstVisitor {

@override

void visitPartOfDirective(PartOfDirective node) {

- isCoreLibrary = node.libraryName?.name == 'dart.core';

+ isCoreLibrary = node.libraryName?.name == 'dart.core' ||

+ node.uri?.stringValue == 'core.dart';

isPartOf = true;

}