Fix the resolution of uri-based part-of directives in the SDK (issue 29598)

Fix the resolution of uri-based part-of directives in the SDK (issue 29598)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d29c5d3a72aa41fa82dee4a0bbb31320848fa5f7

[Brian Wilkerson, 2017-06-29 19:49:25]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-06-29 19:49:26]

I don't know that this will fix all of the issues, because I can't duplicate the
original failure, but I'm confident this is an improvement. If you can think of
other places that might need to be updated, please let me know.

[scheglov, 2017-06-29 20:19:24]

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:662: return
file.createSource(Uri.parse(dartUri));
Maybe extract the URI into a variable and update it in "if (relativeFile.path ==
file.path)".

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/source_test.dart (right):

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/source_test.dart:33:
expect(sourceFactory.resolveUri(numSource, 'core.dart'), coreSource);
We test functionality of DartSdk, so it would be logical to put the test into
the corresponding DartSdk tests, not into SourceFactory test.

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/source_test.dart:69: _createFile(sdkDirectory,
['lib', 'core', 'num.dart']);
Hm... Why do we need all the rest if we use only core?

[Brian Wilkerson, 2017-06-29 20:47:16]

ptal

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:662: return
file.createSource(Uri.parse(dartUri));
I don't know what problem that would solve.

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/source_test.dart (right):

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/source_test.dart:33:
expect(sourceFactory.resolveUri(numSource, 'core.dart'), coreSource);
Done

[scheglov, 2017-06-29 20:50:38]

LGTM

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2967503002/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:662: return
file.createSource(Uri.parse(dartUri));
On 2017/06/29 20:47:15, Brian Wilkerson wrote:
> I don't know what problem that would solve.

Well, it's not a problem, just avoid duplication of file.createSource()
invocation code. Not important.

[Brian Wilkerson, 2017-06-29 20:51:48]

Description was changed from

==========
Fix the resolution of uri-based part-of directives in the SDK (issue 29598)
==========

to

==========
Fix the resolution of uri-based part-of directives in the SDK (issue 29598)

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d29c5d3a72aa41fa82dee4a0bbb31320848fa5f7
==========

[Brian Wilkerson, 2017-06-29 20:51:50]

Committed patchset #2 (id:20001) manually as
d29c5d3a72aa41fa82dee4a0bbb31320848fa5f7 (presubmit successful).