[Extensions Bindings] Fix getPlatform() method

extensions/renderer/resources/binding.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var Event = require('event_bindings').Event;
 var forEach = require('utils').forEach;
 // Note: Beware sneaky getters/setters when using GetAvailbility(). Use safe/raw
 // variables as arguments.
 var GetAvailability = requireNative('v8_context').GetAvailability;
 var exceptionHandler = require('uncaught_exception_handler');
 var lastError = require('lastError');
 var loadTypeSchema = require('json_schema').loadTypeSchema;
 var logActivity = requireNative('activityLogger');
 var logging = requireNative('logging');
 var process = requireNative('process');
 var schemaRegistry = requireNative('schema_registry');
 var schemaUtils = require('schemaUtils');
 var sendRequestHandler = require('sendRequest');
 
 var contextType = process.GetContextType();
 var extensionId = process.GetExtensionId();
 var manifestVersion = process.GetManifestVersion();
+var platform = process.GetPlatform();
 var sendRequest = sendRequestHandler.sendRequest;
 
 // Stores the name and definition of each API function, with methods to
 // modify their behaviour (such as a custom way to handle requests to the
 // API, a custom callback, etc).
 function APIFunctions(namespace) {
   this.apiFunctions_ = { __proto__: null };
   this.unavailableApiFunctions_ = { __proto__: null };
   this.namespace = namespace;
 }
@@ skipping 47 matching lines @@
     function(apiName, customizedFunction) {
   return this.setHook_(
     apiName, 'updateArgumentsPreValidate', customizedFunction);
 };
 
 APIFunctions.prototype.setCustomCallback =
     function(apiName, customizedFunction) {
   return this.setHook_(apiName, 'customCallback', customizedFunction);
 };
 
-// Get the platform from navigator.appVersion.
-function getPlatform() {
-  var platforms = [
-    [/CrOS Touch/, "chromeos touch"],

[lazyboy, 2017/07/07 23:09:26]

You're also removing "chromeos touch", which is unused as far as I understand.
Archeology gives me this:
https://codereview.chromium.org/7104002/diff/20002/chrome/common/extensions/a...

Mind updating the CL description to also say it removes "chromeos touch"?

[Devlin, 2017/07/10 18:35:31]

Good idea; done.

-    [/CrOS/, "chromeos"],
-    [/Linux/, "linux"],
-    [/Mac/, "mac"],
-    [/Win/, "win"],
-  ];
-
-  for (var i = 0; i < platforms.length; i++) {
-    if ($RegExp.exec(platforms[i][0], navigator.appVersion)) {
-      return platforms[i][1];
-    }
-  }
-  return "unknown";
-}
-
 function isPlatformSupported(schemaNode, platform) {
   return !schemaNode.platforms ||
       $Array.indexOf(schemaNode.platforms, platform) > -1;
 }
 
 function isManifestVersionSupported(schemaNode, manifestVersion) {
   return !schemaNode.maximumManifestVersion ||
       manifestVersion <= schemaNode.maximumManifestVersion;
 }
 
@@ skipping 20 matching lines @@
   logging.CHECK($Array.indexOf(whitelistedModules, jsModuleName) !== -1,
                 'Module ' + jsModuleName + ' does not define a custom type.');
   var jsModule = require(jsModuleName);
   logging.CHECK(jsModule, 'No module ' + jsModuleName + ' found for ' +
                 type.id + '.');
   var customType = jsModule[jsModuleName];
   logging.CHECK(customType, jsModuleName + ' must export itself.');
   return customType;
 }
 
-var platform = getPlatform();
-
 function Binding(apiName) {
   this.apiName_ = apiName;
   this.apiFunctions_ = new APIFunctions(apiName);
   this.customHooks_ = [];
 };
 
 $Object.defineProperty(Binding, 'create', {
   __proto__: null,
   configurable: false,
   enumerable: false,
@@ skipping 380 matching lines @@
                     availability.message);
       return;
     }
 
     this.runHooks_(mod, schema);
     return mod;
   }
 };
 
 exports.$set('Binding', Binding);