Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 296743003: Removed RecalcStyleTime. (Closed)

Created:
6 years, 7 months ago by rune
Modified:
6 years, 7 months ago
Reviewers:
ojan
CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, caseq+blink_chromium.org, krit, malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, pdr., rwlbuis, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, Stephen Chennney, gavinp+prerender_chromium.org, kouhei+svg_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), sergeyv+blink_chromium.org, esprehn, eseidel
Visibility:
Public.

Description

Removed RecalcStyleTime. All style resolver changes are now deferred. R=ojan@chromium.org BUG=374162 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174634

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -45 lines) Patch
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 chunks +5 lines, -10 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 6 chunks +10 lines, -13 lines 0 comments Download
M Source/core/dom/StyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rune
This CL needs a rebase after landing the two remaining CLs for RecalcStyleImmediately -> RecalcStyleDeferred. ...
6 years, 7 months ago (2014-05-20 13:15:12 UTC) #1
ojan
lgtm <3
6 years, 7 months ago (2014-05-20 19:24:37 UTC) #2
rune
The CQ bit was checked by rune@opera.com
6 years, 7 months ago (2014-05-22 17:36:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/296743003/20001
6 years, 7 months ago (2014-05-22 17:36:57 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 01:57:26 UTC) #5
Message was sent while issue was closed. 
Change committed as 174634

Powered by Google App Engine
This is Rietveld 408576698