Issue 2967413002: Split driver_test main() into 4 tests methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2967413002: Split driver_test main() into 4 tests methods. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Split driver_test main() into 4 tests methods. This is not how I would ideally prefer to write tests, but a bit better. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/956b9ce96bc2fc6003e5fc7859fb4100f7dcf382

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+410 lines, -399 lines)			Patch
	M	pkg/analyzer_cli/test/driver_test.dart	View		2 chunks	+410 lines, -399 lines	0 comments	Download

Total messages: 6 (1 generated)

Brian Wilkerson

lgtm. I'm assuming that the content of the tests didn't change.

3 years, 5 months ago (2017-07-06 20:06:48 UTC) #2

scheglov

On 2017/07/06 20:06:48, Brian Wilkerson wrote: > lgtm. I'm assuming that the content of the ...

3 years, 5 months ago (2017-07-06 20:14:45 UTC) #3

scheglov

3 years, 5 months ago (2017-07-06 21:12:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
956b9ce96bc2fc6003e5fc7859fb4100f7dcf382 (presubmit successful).