Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2967363003: enable fasta scanner in analyzer by default (Closed)

Created:
3 years, 5 months ago by danrubel
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry, ahe
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

enable fasta scanner in analyzer by default * update test because fasta scanner correctly warns on 1.e+2 * fasta scanner correctly produces compile time error see dartbug.com/28664 fix dartbug.com/28680 * update fasta AsciiControlCharacter error code * enable fasta scanner in analyzer by default R=ahe@google.com, paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/4da09b06d05352b1a8a8a7d8b1fbda183cb34e9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/scanner/scanner.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/number_identifier_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
danrubel
3 years, 5 months ago (2017-07-06 17:15:52 UTC) #2
Paul Berry
lgtm
3 years, 5 months ago (2017-07-06 17:29:46 UTC) #3
ahe
lgtm Woot!
3 years, 5 months ago (2017-07-06 17:30:28 UTC) #5
danrubel
3 years, 5 months ago (2017-07-06 17:36:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4da09b06d05352b1a8a8a7d8b1fbda183cb34e9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698