Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: build/config/c++/BUILD.gn

Issue 2967263002: Fix V8 gcc build when using libc++ (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/c++/BUILD.gn
diff --git a/build/config/c++/BUILD.gn b/build/config/c++/BUILD.gn
index 21316ba1c8bd3160c4b08a0a65bea5b72871e6c9..baad310d724d423cada78d237f0f06b2607b2985 100644
--- a/build/config/c++/BUILD.gn
+++ b/build/config/c++/BUILD.gn
@@ -8,6 +8,12 @@ config("c++flags") {
if (use_custom_libcxx) {
prefix = "//buildtools/third_party"
include = "trunk/include"
+ if (!is_clang) {
+ # Gcc has a built-in abs() definition with default visibility.
+ # If it was not disabled, it would conflict with libc++'s abs()
+ # with hidden visibility.
+ cflags = [ "-fno-builtin-abs" ]
+ }
cflags_cc = [
"-nostdinc++",
"-isystem" + rebase_path("$prefix/libc++/$include", root_build_dir),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698