Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 296723005: Revert 174428 "Update Gamepad.axes / GamepadButton.value to matc..." (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Inactive
CC:
blink-reviews
Visibility:
Public.

Description

Revert 174428 "Update Gamepad.axes / GamepadButton.value to matc..." Broke Windows Debug build. See Issue 344556 for details. > Update Gamepad.axes / GamepadButton.value to match the latest specification > > Update Gamepad.axes / GamepadButton.value to match the latest specification: > https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#widl-Gamepad-axes > https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#widl-GamepadButton-value > > Those attributes should be of type double as per the specification but Blink > was still using float type as in older version of the specification. This can > lead to precision problem on JavaScript side. > > This CL introduces temporary ENABLE_NEW_GAMEPAD_API #ifdefs to help with the > transition. Those will be removed once the Chromium side has been updated. > > R=eseidel@chromium.org, bajones@chromium.org > BUG=344556 > TEST=gamepad/gamepad-events-basic.html > > Review URL: https://codereview.chromium.org/280393004 TBR=ch.dumez@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -40 lines) Patch
M trunk/LayoutTests/gamepad/gamepad-events-basic.html View 3 chunks +7 lines, -12 lines 0 comments Download
M trunk/LayoutTests/gamepad/gamepad-events-basic-expected.txt View 1 chunk +5 lines, -8 lines 0 comments Download
M trunk/Source/modules/gamepad/Gamepad.idl View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/gamepad/GamepadButton.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/modules/gamepad/GamepadButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/gamepad/GamepadButton.idl View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/gamepad/GamepadCommon.h View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/modules/gamepad/GamepadCommon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/public/platform/WebGamepad.h View 4 chunks +5 lines, -8 lines 0 comments Download
M trunk/public/platform/WebGamepads.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-21 00:32:18 UTC) #1
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-21 00:32:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r174433.

Powered by Google App Engine
This is Rietveld 408576698