Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 296723004: Simplified android_builder and moved internal-only methods to internal module (Closed)

Created:
6 years, 7 months ago by luqui
Modified:
6 years, 7 months ago
Reviewers:
navabi1, navabi, zty
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Simplified android_builder and moved internal-only methods to internal module Internal side https://chromereviews.googleplex.com/42137013/ and https://chromereviews.googleplex.com/45097017/ BUG=375007 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=272612

Patch Set 1 #

Patch Set 2 : Coverage #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -3574 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 2 5 chunks +9 lines, -86 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json View 1 2 3 chunks +40 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json View 1 2 3 chunks +40 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json View 1 2 3 chunks +40 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/linux.json View 1 1 chunk +18 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/mac.json View 1 1 chunk +18 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/win.json View 1 1 chunk +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/android_builder.py View 1 2 1 chunk +12 lines, -121 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/arm_builder.json View 1 2 1 chunk +0 lines, -268 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/arm_builder_rel.json View 1 2 1 chunk +0 lines, -268 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/clang_builder.json View 1 2 1 chunk +0 lines, -300 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/clang_builder_findbugs_failure.json View 1 2 1 chunk +0 lines, -323 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/clang_release_builder.json View 1 2 1 chunk +0 lines, -307 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/component_builder.json View 1 2 1 chunk +0 lines, -268 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/dartium_builder.json View 1 2 1 chunk +0 lines, -201 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/main_builder.json View 1 2 1 chunk +0 lines, -268 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/mipsel_builder.json View 1 2 1 chunk +0 lines, -264 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/try_builder.json View 1 2 1 chunk +0 lines, -313 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/x86_builder.json View 1 2 1 chunk +0 lines, -268 lines 0 comments Download
D scripts/slave/recipes/android/android_builder.expected/x86_try_builder.json View 1 2 1 chunk +0 lines, -313 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
luqui
ptal See note on other half.
6 years, 7 months ago (2014-05-20 23:54:37 UTC) #1
navabi
Discussed in person lgtm.
6 years, 7 months ago (2014-05-21 05:37:55 UTC) #2
luqui
The CQ bit was checked by luqui@chromium.org
6 years, 7 months ago (2014-05-23 22:11:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luqui@chromium.org/296723004/40001
6 years, 7 months ago (2014-05-23 22:12:12 UTC) #4
commit-bot: I haz the power
Change committed as 272612
6 years, 7 months ago (2014-05-23 22:13:13 UTC) #5
luqui
6 years, 7 months ago (2014-05-23 23:10:20 UTC) #6
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/297793005/ by luqui@chromium.org.

The reason for reverting is: I needed to coordinate this with master restarts..

Powered by Google App Engine
This is Rietveld 408576698