Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 296723003: MIPS: Avoid flushing the icache unnecessarily when updating target addresses in code. (Closed)

Created:
6 years, 7 months ago by kilvadyb
Modified:
6 years, 7 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Avoid flushing the icache unnecessarily when updating target addresses in code. Port r21380 (ef20a0a) Original commit message: This CL updates RelocInfo update operations and set_target_address_at to enable skipping of the icache flush if it going to be batched up later. Code::CopyFrom and Code::Relocate are modified to avoid individual icache flushes since the whole code area will be flushed after the reloc info is updated. These changes reduce a regression when enabling the OOL constant pool on Arm, since this change can cause MovT/MovW instructions for relocatable targets if the constant pool is full. Scores for Mandreel latency on a Nexus 5: - OOL CP disabled: 3533 - OOL CP enabled, without this CL: 1825 - OOL CP enabled, with change: 3015 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M src/mips/assembler-mips.h View 3 chunks +12 lines, -5 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 6 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
6 years, 7 months ago (2014-05-20 13:15:13 UTC) #1
Paul Lind
lgtm
6 years, 7 months ago (2014-05-20 14:47:03 UTC) #2
Paul Lind
6 years, 7 months ago (2014-05-20 14:49:39 UTC) #3
Committed as r21390.

Powered by Google App Engine
This is Rietveld 408576698