Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2967203002: Remove CompilationUnitElement.getElementAt(). (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CompilationUnitElement.getElementAt(). It is not used by any package we use internally. It was added for search, but is not used anymore. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7ea7324747ca876d6cf2d93c1eb8e3b403f13203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -141 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 5 chunks +0 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/mock_element.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-05 17:41:13 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-05 17:51:00 UTC) #2
scheglov
3 years, 5 months ago (2017-07-05 17:52:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ea7324747ca876d6cf2d93c1eb8e3b403f13203 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698