Change UnusedLocalElementsVerifier to AST visitor.

Change UnusedLocalElementsVerifier to AST visitor.

We are moving to excluding local elements from the element model,
so we cannot use element visitor to visit and report local elements.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/cf66612116c55d38a053950784651479f78b5c76

[Brian Wilkerson, 2017-07-05 17:07:23]

lgtm

https://codereview.chromium.org/2967183002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2967183002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:10314: class
UnusedLocalElementsVerifier extends GeneralizingAstVisitor {
I think a RecursiveAstVisitor would work and be more efficient.

[scheglov, 2017-07-05 17:11:54]

https://codereview.chromium.org/2967183002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2967183002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:10314: class
UnusedLocalElementsVerifier extends GeneralizingAstVisitor {
On 2017/07/05 17:07:23, Brian Wilkerson wrote:
> I think a RecursiveAstVisitor would work and be more efficient.

Acknowledged.

[scheglov, 2017-07-05 17:12:10]

Description was changed from

==========
Change UnusedLocalElementsVerifier to AST visitor.

We are moving to excluding local elements from the element model,
so we cannot use element visitor to visit and report local elements.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Change UnusedLocalElementsVerifier to AST visitor.

We are moving to excluding local elements from the element model,
so we cannot use element visitor to visit and report local elements.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/cf66612116c55d38a053950784651479f78b5c76
==========

[scheglov, 2017-07-05 17:12:11]

Committed patchset #1 (id:1) manually as
cf66612116c55d38a053950784651479f78b5c76 (presubmit successful).