Improve warnings related to incorrect 'part of' declarations.

Improve warnings related to incorrect 'part of' declarations.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/f1f884011fec6b08874951cb617a706d132c150e

[ahe, 2017-07-05 12:30:42]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-07-05 12:44:24]

lgtm

https://codereview.chromium.org/2967143002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2967143002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:430: addWarning(
This warning should only be emitted if `part.partOfName != name`, right?

[ahe, 2017-07-05 13:01:02]

Thank you, Johnni.

Great catch!

https://codereview.chromium.org/2967143002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2967143002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:430: addWarning(
On 2017/07/05 12:44:24, Johnni Winther wrote:
> This warning should only be emitted if `part.partOfName != name`, right?

Done.

[ahe, 2017-07-05 13:23:02]

Description was changed from

==========
Improve warnings related to incorrect 'part of' declarations.
==========

to

==========
Improve warnings related to incorrect 'part of' declarations.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f1f884011fec6b08874951cb617a706d132c150e
==========

[ahe, 2017-07-05 13:23:03]

Committed patchset #2 (id:20001) manually as
f1f884011fec6b08874951cb617a706d132c150e (presubmit successful).