Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 296713003: Make sure that OOBE resumes at the update screen when update was done. (Closed)

Created:
6 years, 7 months ago by pastarmovj
Modified:
6 years, 6 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, Mattias Nissler (ping if slow)
Visibility:
Public.

Description

Make sure that OOBE resumes at the update screen when update was done. This is critical to make sure that forced reenrollment check is not skipped in case of critical updates. BUG=372368 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273195

Patch Set 1 #

Patch Set 2 : Fixed the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pastarmovj
Based on the new oobe screen bookkeeping we don't have to mark oobe complete to ...
6 years, 7 months ago (2014-05-22 13:43:40 UTC) #1
ygorshenin1
lgtm
6 years, 7 months ago (2014-05-27 09:50:54 UTC) #2
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org
6 years, 7 months ago (2014-05-27 10:06:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/296713003/1
6 years, 7 months ago (2014-05-27 10:07:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 13:38:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 13:44:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77896)
6 years, 7 months ago (2014-05-27 13:44:06 UTC) #7
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org
6 years, 6 months ago (2014-05-28 08:40:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/296713003/20001
6 years, 6 months ago (2014-05-28 08:41:32 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 10:36:30 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 13:17:27 UTC) #11
Message was sent while issue was closed.
Change committed as 273195

Powered by Google App Engine
This is Rietveld 408576698