ios/showcase/text_badge_view/BUILD.gn - Issue 2967113003: [ios showcase] Integrated TextBadgeView with Showcase.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/showcase/text_badge_view/BUILD.gn

Issue 2967113003: [ios showcase] Integrated TextBadgeView with Showcase. (Closed)

Patch Set: Added text badge to view controller and created egtest stub Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/showcase/core/showcase_model.mm ('k') | ios/showcase/text_badge_view/text_badge_view_egtest.mm » ('j') | ios/showcase/text_badge_view/text_badge_view_egtest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 source_set("text_badge_view") {

	2 sources = [

	3 "text_badge_view_view_controller.h",
	edchin 2017/07/07 04:38:03 I see why you reiterated the word 'view'. Please I see why you reiterated the word 'view'. Please remove the duplicate. It looks better if you do so. gchatz 2017/07/07 04:40:38 New files should follow showcase convention where New files should follow showcase convention where "sc_" is prepended. edchin 2017/07/07 05:00:49 I agree with gchatz. But, I can see why you didn't Show quoted text On 2017/07/07 04:40:38, gchatz wrote: > New files should follow showcase convention where "sc_" is prepended. I agree with gchatz. But, I can see why you didn't follow the convention. The only view controller in the example list does not use the prepend, while all coordinators do. I think it makes sense to use the convention. helenlyang 2017/07/07 16:31:12 Done. Show quoted text On 2017/07/07 04:38:03, edchin wrote: > I see why you reiterated the word 'view'. > Please remove the duplicate. It looks better if you do so. Done.
	4 "text_badge_view_view_controller.mm",

	5 ]

	6 deps = [

	7 "//ios/chrome/browser/ui/reading_list:reading_list_ui",

	8 ]

	9 libs = [ "UIKit.framework" ]

	10 configs += [ "//build/config/compiler:enable_arc" ]

	11 }

	12

	13 source_set("eg_tests") {

	14 testonly = true

	15 sources = [

	16 "text_badge_view_egtest.mm",

	17 ]

	18 deps = [

	19 "//ios/chrome/browser/ui/reading_list:reading_list_ui",

	20 "//ios/chrome/test/earl_grey:test_support",

	21 "//ios/showcase/test",

	22 "//ios/third_party/earl_grey",

	23 "//ui/base",

	24 ]

	25 configs += [ "//build/config/compiler:enable_arc" ]

	26 }

OLD	NEW