|
|
Created:
6 years, 7 months ago by Sergey Ulanov Modified:
6 years, 7 months ago Reviewers:
Wez CC:
chromium-reviews, chromoting-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionChange video channel timeout to 2 seconds instead of 1
BUG=375568
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272788
Patch Set 1 #
Messages
Total messages: 22 (0 generated)
What's this number based upon? With the current timeout I observe sessions to basically responsive hosts regularly becoming greyed out and unresponsive; is two seconds sufficiently much longer to avoid these transient delays being escalated into grey-outs or disconnects?
On 2014/05/23 01:05:48, Wez wrote: > What's this number based upon? > > With the current timeout I observe sessions to basically responsive hosts > regularly becoming greyed out and unresponsive; is two seconds sufficiently much > longer to avoid these transient delays being escalated into grey-outs or > disconnects? The logic here is that if connection is inactive for 2 seconds it's not usable, so we want to gray it out. 1 second is too aggressive. MonitoredVideoStub doesn't reconnect connection itself. It just tells the webapp that video channel is not active. When video channel becomes inactive the webapp may reconnect immediately. See https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/sm... . Currently it checks if the client is online and reconnects immediately only when it's online, otherwise it waits for 10 seconds. I'm not sure that's the right solution - it will cause spurious reconnects on a flaky network, but it's separate from this change. This change should prevent the screen from being grayed out too often on a slower networks.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/296703013/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/296703013/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/296703013/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/296703013/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
Message was sent while issue was closed.
Change committed as 272788 |