Issue 296703012: Revert "Remove override of View::HitTestRect() from ImageView"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296703012: Revert "Remove override of View::HitTestRect() from ImageView" (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher

Modified:
6 years, 7 months ago

Reviewers:
tdanderson, sadrul, sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "Remove override of View::HitTestRect() from ImageView" This patch reverts r272117, which broke the prelight state on toolbar buttons. BUG=376478, 374325 TBR=sadrul@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272315

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	ui/views/controls/image_view.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	ui/views/controls/image_view.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Elliot Glaysher

sadrul or sky: owners stamp for straight revert tdanderson: fyi

6 years, 7 months ago (2014-05-22 20:58:06 UTC) #1

Elliot Glaysher

On 2014/05/22 20:58:06, Elliot Glaysher wrote: > sadrul or sky: owners stamp for straight revert ...

6 years, 7 months ago (2014-05-22 21:04:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/296703012/1

6 years, 7 months ago (2014-05-22 21:06:04 UTC) #4

Message was sent while issue was closed.

Change committed as 272315