Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: Source/core/dom/custom/CustomElementMicrotaskDispatcher.h

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix compilation issue pointed out by clang Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/custom/CustomElementMicrotaskDispatcher.h
diff --git a/Source/core/dom/custom/CustomElementMicrotaskDispatcher.h b/Source/core/dom/custom/CustomElementMicrotaskDispatcher.h
index a3f7669c94426d2b05ebba69e2bf1c65e59f7ae3..46ef3f56afce027b5f9501b19b6057488131c19f 100644
--- a/Source/core/dom/custom/CustomElementMicrotaskDispatcher.h
+++ b/Source/core/dom/custom/CustomElementMicrotaskDispatcher.h
@@ -6,6 +6,7 @@
#define CustomElementMicrotaskDispatcher_h
#include "core/dom/custom/CustomElementMicrotaskQueue.h"
+#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/Vector.h"
@@ -17,20 +18,22 @@ class CustomElementMicrotaskImportStep;
class CustomElementMicrotaskStep;
class HTMLImportLoader;
-class CustomElementMicrotaskDispatcher {
+class CustomElementMicrotaskDispatcher FINAL : public NoBaseWillBeGarbageCollected<CustomElementMicrotaskDispatcher> {
WTF_MAKE_NONCOPYABLE(CustomElementMicrotaskDispatcher);
+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(CustomElementMicrotaskDispatcher);
public:
- ~CustomElementMicrotaskDispatcher() { }
static CustomElementMicrotaskDispatcher& instance();
- void enqueue(HTMLImportLoader*, PassOwnPtr<CustomElementMicrotaskStep>);
+ void enqueue(HTMLImportLoader*, PassOwnPtrWillBeRawPtr<CustomElementMicrotaskStep>);
void enqueue(CustomElementCallbackQueue*);
void importDidFinish(CustomElementMicrotaskImportStep*);
bool elementQueueIsEmpty() { return m_elements.isEmpty(); }
+ void trace(Visitor*);
+
#if !defined(NDEBUG)
void show();
#endif
@@ -50,8 +53,8 @@ private:
DispatchingCallbacks
} m_phase;
- RefPtr<CustomElementMicrotaskQueue> m_resolutionAndImports;
- Vector<CustomElementCallbackQueue*> m_elements;
+ RefPtrWillBeMember<CustomElementMicrotaskQueue> m_resolutionAndImports;
+ WillBeHeapVector<RawPtrWillBeMember<CustomElementCallbackQueue> > m_elements;
};
}
« no previous file with comments | « Source/core/dom/custom/CustomElementDescriptor.h ('k') | Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698