Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: Source/core/dom/custom/CustomElementCallbackQueue.h

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix compilation issue pointed out by clang Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/custom/CustomElementCallbackQueue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/custom/CustomElementCallbackQueue.h
diff --git a/Source/core/dom/custom/CustomElementCallbackQueue.h b/Source/core/dom/custom/CustomElementCallbackQueue.h
index cae58558f7645bd07e0ddf9bb9a98243a00280f5..015f6ecc61175624b65f6d73eb65d26cb70cbe08 100644
--- a/Source/core/dom/custom/CustomElementCallbackQueue.h
+++ b/Source/core/dom/custom/CustomElementCallbackQueue.h
@@ -33,6 +33,7 @@
#include "core/dom/Element.h"
#include "core/dom/custom/CustomElementProcessingStep.h"
+#include "platform/heap/Handle.h"
#include "wtf/OwnPtr.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/PassRefPtr.h"
@@ -43,10 +44,10 @@ namespace WebCore {
// FIXME: Rename this because it contains resolution and upgrade as
// well as callbacks.
-class CustomElementCallbackQueue {
+class CustomElementCallbackQueue : public NoBaseWillBeGarbageCollectedFinalized<CustomElementCallbackQueue> {
WTF_MAKE_NONCOPYABLE(CustomElementCallbackQueue);
public:
- static PassOwnPtr<CustomElementCallbackQueue> create(PassRefPtr<Element>);
+ static PassOwnPtrWillBeRawPtr<CustomElementCallbackQueue> create(PassRefPtrWillBeRawPtr<Element>);
typedef int ElementQueueId;
ElementQueueId owner() const { return m_owner; }
@@ -64,10 +65,12 @@ public:
void append(PassOwnPtr<CustomElementProcessingStep> invocation) { m_queue.append(invocation); }
bool inCreatedCallback() const { return m_inCreatedCallback; }
+ void trace(Visitor*);
+
private:
- CustomElementCallbackQueue(PassRefPtr<Element>);
+ explicit CustomElementCallbackQueue(PassRefPtrWillBeRawPtr<Element>);
- RefPtr<Element> m_element;
+ RefPtrWillBeMember<Element> m_element;
Vector<OwnPtr<CustomElementProcessingStep> > m_queue;
ElementQueueId m_owner;
size_t m_index;
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/custom/CustomElementCallbackQueue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698