Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: Source/core/dom/custom/CustomElementDescriptor.h

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/custom/CustomElementDescriptor.h
diff --git a/Source/core/dom/custom/CustomElementDescriptor.h b/Source/core/dom/custom/CustomElementDescriptor.h
index 7a3c6719bcc6a54a3e38842c7b67f5ee70c0eaa9..5d3a36a8423b69b62d18056bed4be97d93931f7e 100644
--- a/Source/core/dom/custom/CustomElementDescriptor.h
+++ b/Source/core/dom/custom/CustomElementDescriptor.h
@@ -31,6 +31,7 @@
#ifndef CustomElementDescriptor_h
#define CustomElementDescriptor_h
+#include "platform/heap/Handle.h"
#include "wtf/HashTableDeletedValueType.h"
#include "wtf/text/AtomicString.h"
@@ -41,6 +42,7 @@ struct CustomElementDescriptorHash;
// A Custom Element descriptor is everything necessary to match a
// Custom Element instance to a definition.
class CustomElementDescriptor {
+ ALLOW_ONLY_INLINE_ALLOCATION();
haraken 2014/05/22 08:24:10 - I think this should be DISALLOW_ALLOCATION, sinc
sof 2014/05/25 16:30:01 I don't understand this comment. A part object doe
haraken 2014/05/26 01:21:40 Sorry, you're right. (I was misunderstanding that
zerny-chromium 2014/05/26 11:01:00 Just to clarify, DISALLOW_ALLOCATION is the strong
public:
CustomElementDescriptor(const AtomicString& type, const AtomicString& namespaceURI, const AtomicString& localName)
: m_type(type)

Powered by Google App Engine
This is Rietveld 408576698