Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: trunk/src/chrome/browser/metrics/metrics_services_manager.cc

Issue 296703008: Revert 271798 "[Metrics] Make MetricsStateManager take a callbac..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/metrics/metrics_services_manager.cc
===================================================================
--- trunk/src/chrome/browser/metrics/metrics_services_manager.cc (revision 271821)
+++ trunk/src/chrome/browser/metrics/metrics_services_manager.cc (working copy)
@@ -4,18 +4,11 @@
#include "chrome/browser/metrics/metrics_services_manager.h"
-#include "base/command_line.h"
#include "chrome/browser/metrics/metrics_service.h"
#include "chrome/browser/metrics/metrics_state_manager.h"
#include "chrome/browser/metrics/variations/variations_service.h"
-#include "chrome/common/chrome_switches.h"
-#include "chrome/common/pref_names.h"
#include "components/rappor/rappor_service.h"
-#if defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/settings/cros_settings.h"
-#endif
-
MetricsServicesManager::MetricsServicesManager(PrefService* local_state)
: local_state_(local_state) {
DCHECK(local_state);
@@ -51,32 +44,7 @@
metrics::MetricsStateManager* MetricsServicesManager::GetMetricsStateManager() {
DCHECK(thread_checker_.CalledOnValidThread());
- if (!metrics_state_manager_) {
- metrics_state_manager_ = metrics::MetricsStateManager::Create(
- local_state_,
- base::Bind(&MetricsServicesManager::IsMetricsReportingEnabled,
- base::Unretained(this)));
- }
+ if (!metrics_state_manager_)
+ metrics_state_manager_ = metrics::MetricsStateManager::Create(local_state_);
return metrics_state_manager_.get();
}
-
-// TODO(asvitkine): This function does not report the correct value on Android,
-// see http://crbug.com/362192.
-bool MetricsServicesManager::IsMetricsReportingEnabled() const {
- // If the user permits metrics reporting with the checkbox in the
- // prefs, we turn on recording. We disable metrics completely for
- // non-official builds, or when field trials are forced.
- if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kForceFieldTrials))
- return false;
-
- bool enabled = false;
-#if defined(GOOGLE_CHROME_BUILD)
-#if defined(OS_CHROMEOS)
- chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref,
- &enabled);
-#else
- enabled = local_state_->GetBoolean(prefs::kMetricsReportingEnabled);
-#endif // #if defined(OS_CHROMEOS)
-#endif // defined(GOOGLE_CHROME_BUILD)
- return enabled;
-}
« no previous file with comments | « trunk/src/chrome/browser/metrics/metrics_services_manager.h ('k') | trunk/src/chrome/browser/metrics/metrics_state_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698