Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 296703007: Linux Sandbox: run all BaselinePolicy tests with sanitizers. (Closed)

Created:
6 years, 7 months ago by jln (very slow on Chromium)
Modified:
6 years, 7 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux Sandbox: run all BaselinePolicy tests with sanitizers. - Allow ioctls TCGETS and FIONREAD with sanitizers. - Allow sched_getaffinity() with sanitizers. - Enable all BaselinePolicy unit tests with sanitizers. BUG=372445 R=mdempsky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271854

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 3 chunks +28 lines, -16 lines 2 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
Matthew: PTAL!
6 years, 7 months ago (2014-05-21 00:06:40 UTC) #1
mdempsky
lgtm https://codereview.chromium.org/296703007/diff/20001/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc File sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc (right): https://codereview.chromium.org/296703007/diff/20001/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc#newcode101 sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc:101: // Required for better stack overflow detection in ...
6 years, 7 months ago (2014-05-21 00:11:12 UTC) #2
jln (very slow on Chromium)
https://codereview.chromium.org/296703007/diff/20001/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc File sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc (right): https://codereview.chromium.org/296703007/diff/20001/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc#newcode101 sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc:101: // Required for better stack overflow detection in ASan. ...
6 years, 7 months ago (2014-05-21 00:14:40 UTC) #3
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 7 months ago (2014-05-21 01:08:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/296703007/20001
6 years, 7 months ago (2014-05-21 01:10:01 UTC) #5
jln (very slow on Chromium)
6 years, 7 months ago (2014-05-21 03:55:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r271854 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698