Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 296703005: <webview>: Make HandleContextMenu easier to refactor (Closed)

Created:
6 years, 7 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
lazyboy, jam, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prehandle_gesture_event
Visibility:
Public.

Description

<webview>: Make HandleContextMenu easier to refactor In the future, BrowserPluginGuest will no longer be a WebContentsDelegate, and so special handling for guests that relies on the internal implementation details of BrowserPlugin should be moved to chrome. BUG=364141, 330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Fady Samuel
6 years, 7 months ago (2014-05-20 21:15:13 UTC) #1
lazyboy
lgtm Also update the CL description a bit saying BrowserPluginGuest would no longer be WCDelegate, ...
6 years, 7 months ago (2014-05-20 21:20:20 UTC) #2
Fady Samuel
I updated the comment, Nasko could you please OWNER review the web_contents_impl.cc change? Thanks!
6 years, 7 months ago (2014-05-20 21:29:30 UTC) #3
nasko
LGTM I'm not an owner for WebContents though, you need someone else.
6 years, 7 months ago (2014-05-22 20:05:35 UTC) #4
Fady Samuel
6 years, 7 months ago (2014-05-23 15:04:15 UTC) #5
jam
lgtm
6 years, 7 months ago (2014-05-23 15:46:25 UTC) #6
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-23 15:48:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/296703005/1
6 years, 7 months ago (2014-05-23 15:49:24 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 19:24:13 UTC) #9
Message was sent while issue was closed.
Change committed as 272579

Powered by Google App Engine
This is Rietveld 408576698