third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp - Issue 2967013002: Be explicit about namespace testing to not mix it with blink::testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

Issue 2967013002: Be explicit about namespace testing to not mix it with blink::testing (Closed)

Patch Set: Dropped mojo parts that need another review. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp ('k') | third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

index 81b1f2c64593e545aa210aa2e807ab370caa4ff3..5a0012ab5a2ca27e2003a81c65f21d0ac0c7cc5a 100644

--- a/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

@@ -516,7 +516,7 @@ TEST_F(SecurityOriginTest, CanonicalizeHost) {

};

for (const TestCase& test : cases) {

- SCOPED_TRACE(testing::Message() << "raw host: '" << test.host << "'");

+ SCOPED_TRACE(::testing::Message() << "raw host: '" << test.host << "'");

String host = String::FromUTF8(test.host);

bool success = false;

String canonical_host = SecurityOrigin::CanonicalizeHost(host, &success);