chrome/browser/media/webrtc/media_stream_device_permission_context.cc - Issue 2966963003: Ensure media permission requests are correctly cancelled when permission prompts are ignored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/media_stream_device_permission_context.cc

Issue 2966963003: Ensure media permission requests are correctly cancelled when permission prompts are ignored (Closed)

Patch Set: Ensure media permission requests are correctly cancelled when permission prompts are ignored Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/webrtc/media_stream_device_permission_context.h ('k') | chrome/browser/permissions/permission_manager.h » ('j') | chrome/browser/permissions/permission_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc/media_stream_device_permission_context.cc

diff --git a/chrome/browser/media/webrtc/media_stream_device_permission_context.cc b/chrome/browser/media/webrtc/media_stream_device_permission_context.cc

index 7a8813f03e4636fa613679c7be33f0db05d12b60..0450d8ba9e6969179593a1eebd4f630ffc8edf12 100644

--- a/chrome/browser/media/webrtc/media_stream_device_permission_context.cc

+++ b/chrome/browser/media/webrtc/media_stream_device_permission_context.cc

@@ -100,12 +100,6 @@ void MediaStreamDevicePermissionContext::ResetPermission(

NOTREACHED() << "ResetPermission is not implemented";

}

-void MediaStreamDevicePermissionContext::CancelPermissionRequest(

- content::WebContents* web_contents,

- const PermissionRequestID& id) {

- NOTREACHED() << "CancelPermissionRequest is not implemented";

bool MediaStreamDevicePermissionContext::IsRestrictedToSecureOrigins() const {

return base::FeatureList::IsEnabled(

features::kRequireSecureOriginsForPepperMediaRequests);