src/ic.cc - Issue 296693011: GCMole evaluation order issue in CallIC::DoCustomHandler().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 296693011: GCMole evaluation order issue in CallIC::DoCustomHandler(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 38a0c149a8378178ac9f1f4f800553e76e9aba8c..90beb36d0dea33301d125f6a383e0c09da0ff776 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1850,7 +1850,8 @@ bool CallIC::DoCustomHandler(Handle<Object> receiver,

isolate()->context()->native_context()->array_function(), isolate());

if (array_function.is_identical_to(Handle<JSFunction>::cast(function))) {

// Alter the slot.

- vector->set(slot->value(), *isolate()->factory()->NewAllocationSite());

+ Handle<AllocationSite> new_site = isolate()->factory()->NewAllocationSite();

+ vector->set(slot->value(), *new_site);

State new_state = state.ToMonomorphicArrayCallState();

CallICStub stub(isolate(), new_state);

set_target(*stub.GetCode());

« no previous file with comments | « no previous file | no next file » | no next file with comments »