[gen_snapshot] Escape spaces when generating depfiles.

[gen_snapshot] Escape spaces when generating depfiles.

Fixes https://github.com/dart-lang/sdk/issues/30059

R=jakobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/6eacc4b7f89a34ddea63dcb689641fdf64be2598

[rmacnak, 2017-06-30 23:41:07]

rmacnak@google.com changed reviewers:
+ cbracken@google.com, jakobr@google.com

[rmacnak, 2017-06-30 23:41:08]

$ ./out/ReleaseX64/gen_snapshot --snapshot-kind=script
--vm_snapshot_data=$PWD/out/ReleaseX64/gen/runtime/bin/vm_snapshot_data.bin
--isolate_snapshot_data=$PWD/out/ReleaseX64/gen/runtime/bin/isolate_snapshot_data.bin
"--script_snapshot=out with spaces.script" --dependencies=out.d
"/usr/local/google/home/rmacnak/hello with spaces.dart" 

$ cat out.d 
out\ with\ spaces.script :
/usr/local/google/home/rmacnak/ssd/dart1/sdk/out/ReleaseX64/gen/runtime/bin/vm_snapshot_data.bin
/usr/local/google/home/rmacnak/ssd/dart1/sdk/out/ReleaseX64/gen/runtime/bin/isolate_snapshot_data.bin
/usr/local/google/home/rmacnak/hello\ with\ spaces.dart

[Chris Bracken, 2017-07-01 00:47:54]

https://codereview.chromium.org/2966903003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2966903003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:767: WritePath(target);
It looks like we've just got one string for the target but IIRC, in Android ARM
AOT builds we emit multiple targets separated by spaces. Will this behave
correctly in that case?

[Jakob Roland Andersen, 2017-07-03 11:46:51]

lgtm

[rmacnak, 2017-07-05 16:51:04]

https://codereview.chromium.org/2966903003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2966903003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:767: WritePath(target);
On 2017/07/01 00:47:54, Chris Bracken wrote:
> It looks like we've just got one string for the target but IIRC, in Android
ARM
> AOT builds we emit multiple targets separated by spaces. Will this behave
> correctly in that case?

Since all four files are generated by the same action, a build system that sees
any one of them as dirty should rerun the action. I've seen that this works in
Ninja.

[rmacnak, 2017-07-05 17:00:22]

Description was changed from

==========
[gen_snapshot] Escape spaces when generating depfiles.

Fixes https://github.com/dart-lang/sdk/issues/30059
==========

to

==========
[gen_snapshot] Escape spaces when generating depfiles.

Fixes https://github.com/dart-lang/sdk/issues/30059

R=jakobr@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6eacc4b7f89a34ddea63dcb689641fdf64be2598
==========

[rmacnak, 2017-07-05 17:00:24]

Committed patchset #1 (id:1) manually as
6eacc4b7f89a34ddea63dcb689641fdf64be2598 (presubmit successful).